/[escript]/trunk/escript/src/DataArrayView.h
ViewVC logotype

Diff of /trunk/escript/src/DataArrayView.h

Parent Directory Parent Directory | Revision Log Revision Log | View Patch Patch

revision 1627 by trankine, Fri Jan 11 07:45:58 2008 UTC revision 1628 by phornby, Fri Jul 11 13:12:46 2008 UTC
# Line 105  class DataArrayView { Line 105  class DataArrayView {
105    
106       Description:       Description:
107       Copy constructor for DataArrayView.       Copy constructor for DataArrayView.
108         FIXME: See later FIXME.
109    
110       \param other - Input -       \param other - Input -
111                  DataArrayView to copy.                  DataArrayView to copy.
# Line 114  class DataArrayView { Line 115  class DataArrayView {
115    ESCRIPT_DLL_API    ESCRIPT_DLL_API
116    DataArrayView(const DataArrayView& other);    DataArrayView(const DataArrayView& other);
117    
118    
119      /**
120         \brief
121         Destructor.
122         FIXME: See later FIXME.
123    
124         NOTE: Be explicit because of the raw pointer member.
125      */
126      ESCRIPT_DLL_API
127      inline virtual
128      ~DataArrayView() { };
129    
130      /**
131         \brief
132         FIXME: See later FIXME.
133    
134         NOTE: Be explicit because of the raw pointer member.
135      */
136      ESCRIPT_DLL_API
137      virtual
138      DataArrayView &
139      operator=( const DataArrayView &other);
140    
141    
142    
143    /**    /**
144       \brief       \brief
145       Copy from a numarray into the data array viewed by this.       Copy from a numarray into the data array viewed by this.
# Line 1462  class DataArrayView { Line 1488  class DataArrayView {
1488    // The data values for the view.    // The data values for the view.
1489    // NOTE: This points to data external to the view.    // NOTE: This points to data external to the view.
1490    // This is just a pointer to an array of ValueType.    // This is just a pointer to an array of ValueType.
1491      // FIXME: JUST a pointer eh?
1492      //        All raw pointers to shared memory need to be replaced... really.
1493      //        Using smart pointers, you can get efficient direct access
1494      //        to pointers if you need it,
1495      //        and you can control it.
1496      //        Do it & huge amounts of pain will go away.
1497      //        Use boost and the
1498      //        typedef boost::shared_ptr<ValueType> ValuePointer;
1499      //        kind of pattern.
1500      //        Oh, "using namepace std" is addictive &
1501      //        bad for your long term health.
1502      //        Use protection, and get used to "std::".
1503      //        If you have foo::bar::har::get_my_car::... driving you crazy,
1504      //        try using "namespace MySpace = foo::bar::har::..."
1505      //        and then use MySpace::
1506      //
1507    ValueType* m_data;    ValueType* m_data;
1508    
1509    //    //
# Line 1481  class DataArrayView { Line 1523  class DataArrayView {
1523    // This can be derived from m_shape by multiplying the size of each dimension, but    // This can be derived from m_shape by multiplying the size of each dimension, but
1524    // is stored here for convenience.    // is stored here for convenience.
1525    int m_noValues;    int m_noValues;
   
1526  };  };
1527    
1528  ESCRIPT_DLL_API bool operator==(const DataArrayView& left, const DataArrayView& right);  ESCRIPT_DLL_API bool operator==(const DataArrayView& left, const DataArrayView& right);

Legend:
Removed from v.1627  
changed lines
  Added in v.1628

  ViewVC Help
Powered by ViewVC 1.1.26