/[escript]
ViewVC logotype

Revision 1789


Jump to revision: Previous Next
Author: phornby
Date: Mon Sep 15 08:34:44 2008 UTC (10 years, 6 months ago)
Changed paths: 1
Log Message:
Near line 288 of SConstruct.

Fixed the HAVE_GETHOSTNAME environment variable setting.
The the test had a "not" that should not be there,
and the wrong env was being Append()'ed.

On linux, this resulted in HAVE_GETHOSTNAME not being -D'ed.

the strcpy at line 78 of 
escript/src/Utils.cpp

was flagged by gcc as an error because
strcpy is not declared on the compilation branch
that compiles if HAVE_GETHOSTNAME is not set.
I have not fixed this.

Also, the hostname buffer is only 64 char long.
Why limit the length of the hostname,
admitting buffer overflow, in a .cpp file?
Why use strcpy in C++?




Changed paths

Path Details
Directorytrunk/SConstruct modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.26